Skip to content

[Tests] Re-enable the tests for integer overflow diagnostics #15811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 13, 2018
Merged

[Tests] Re-enable the tests for integer overflow diagnostics #15811

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
82f0bb1
[Tests] Re-enable the tests for integer overflow diagnostics
ravikandhadai Apr 3, 2018
6da6937
[Tests] Fix Radar problem <rdar:/19508336>
ravikandhadai Apr 13, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 0 additions & 17 deletions test/SILOptimizer/diagnostic_constant_propagation.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
// RUN: %target-swift-frontend -emit-sil -primary-file %s -o /dev/null -verify
//
// REQUIRES: PTRSIZE=64
//
// These are tests for diagnostics produced by constant propagation pass.
// Due to the change in the implementation of Integer initializers some of the
// tests here that must fail don't currently. Such tests have comments
Expand All @@ -10,9 +8,6 @@
// References: <rdar://problem/29937936>, <rdar://problem/29939484>,
// <https://bugs.swift.org/browse/SR-5964>, <rdar://problem/39120081>

// FIXME: <rdar://problem/19508336> Extend
// test/SILOptimizer/diagnostic_constant_propagation.swift to 32-bit platforms

func testArithmeticOverflow() {
let xu8 : UInt8 = 250
let yu8 : UInt8 = 250
Expand Down Expand Up @@ -258,12 +253,6 @@ func testDivision() {
}

func testPostIncOverflow() {
var s_max = Int.max
s_max += 1 // expected-error {{arithmetic operation '9223372036854775807 + 1' (on type 'Int') results in an overflow}}

var u_max = UInt.max
u_max += 1 // expected-error {{arithmetic operation '18446744073709551615 + 1' (on type 'UInt') results in an overflow}}

var s8_max = Int8.max
s8_max += 1 // expected-error {{arithmetic operation '127 + 1' (on type 'Int8') results in an overflow}}

Expand All @@ -290,12 +279,6 @@ func testPostIncOverflow() {
}

func testPostDecOverflow() {
var s_min = Int.min
s_min -= 1 // expected-error {{arithmetic operation '-9223372036854775808 - 1' (on type 'Int') results in an overflow}}

var u_min = UInt.min
u_min -= 1 // expected-error {{arithmetic operation '0 - 1' (on type 'UInt') results in an overflow}}

var s8_min = Int8.min
s8_min -= 1 // expected-error {{arithmetic operation '-128 - 1' (on type 'Int8') results in an overflow}}

Expand Down
Loading