[Parsing] NFC: metaprogram contextual decl keywords into Attr.def #15818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
slavapestov
approved these changes
Apr 7, 2018
|
Hi @slavapestov – Thanks for the positive review! It looks like SourceKit didn't deal with |
davezarzycki
force-pushed
the
nfc_metaprogram_contextual_decl_keywords
branch
from
96b78d1 to
f346f05
Compare
|
@swift-ci please smoke test |
davezarzycki
force-pushed
the
nfc_metaprogram_contextual_decl_keywords
branch
from
f346f05 to
00edd55
Compare
|
I made a mistake with @swift-ci please smoke test |
davezarzycki
force-pushed
the
nfc_metaprogram_contextual_decl_keywords
branch
from
00edd55 to
7174d14
Compare
|
@swift-ci please smoke test |
|
I feel more confident now that this was merely a SourceKit bug. We can always revert this if somebody complains. |
|
Yeah, I agree this is also a SourceKit enhancement. Thank you for fixing it, @davezarzycki ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier to add new contextual keywords to the compiler after updating
Attr.def.NEEDS REVIEW:
openand__consumingwere inconsistently handled across the compiler. Was/is this intentional?This passes validation testing on my Linux box.