Opportunistic fix to allow \Derived.property to be inferred as \Base.… #15903
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…property. Noticed this opportunity while reading through the keypath type checking code.
|
@jckarter I'm not sure if this is really useful/desirable. The diagnostic in the second case could certainly be more helpful, but that would probably not be straightforward to fix. What do you think? |
|
This seems a little funny, but it's useful for source compatibility. If a third-party developer refactors their published library to move common functionality into a superclass, that shouldn't break source. |
|
It seems reasonable to me for this to work. |
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…property.
Noticed this opportunity while reading through the keypath type checking code.