stdlib: silence truncation warning on Windows #15919
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The returned type `std::streamoff` on Windows x64 is a `long long` rather than `int`. This results in a 64-to-32 bit shortening of the value. Use the appropriate type to avoid the truncation. `strlen` returns a unsigned value, but `std::streamoff` is an signed value. Explicitly cast the value to avoid the warning about the implicit signed conversion.
|
@swift-ci please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The returned type
std::streamoffon Windows x64 is along longrather than
int. This results in a 64-to-32 bit shortening of thevalue. Use the appropriate type to avoid the truncation.
strlenreturns a unsigned value, butstd::streamoffis an signedvalue. Explicitly cast the value to avoid the warning about the
implicit signed conversion.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.