Skip to content

[gardening] cleanup a dead UID and tweak a comment #15925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 13, 2018
Merged

[gardening] cleanup a dead UID and tweak a comment #15925

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e08c317
[sourcekit] Remove dead UID value
benlangmuir Apr 13, 2018
45936f5
[gardening] Tweak comment wording
benlangmuir Apr 13, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/IDE/Formatting.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -668,7 +668,7 @@ class FormatWalker : public SourceEntityWalker {
SiblingCollector SCollector;

/// Sometimes, target is a part of "parent", for instance, "#else" is a part
/// of an ifconfigstmt, so that ifconfigstmt is not really the parent of "#else".
/// of an IfConfigDecl, so that IfConfigDecl is not really the parent of "#else".
bool isTargetPartOf(swift::ASTWalker::ParentTy Parent) {
if (auto Conf = dyn_cast_or_null<IfConfigDecl>(Parent.getAsDecl())) {
for (auto Clause : Conf->getClauses()) {
Expand Down
2 changes: 0 additions & 2 deletions tools/SourceKit/tools/complete-test/complete-test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@ static sourcekitd_uid_t KeyRequest;
static sourcekitd_uid_t KeyCompilerArgs;
static sourcekitd_uid_t KeyOffset;
static sourcekitd_uid_t KeyLength;
static sourcekitd_uid_t KeyActionable;
static sourcekitd_uid_t KeySourceFile;
static sourcekitd_uid_t KeySourceText;
static sourcekitd_uid_t KeyName;
Expand Down Expand Up @@ -286,7 +285,6 @@ static int skt_main(int argc, const char **argv) {
KeyCompilerArgs = sourcekitd_uid_get_from_cstr("key.compilerargs");
KeyOffset = sourcekitd_uid_get_from_cstr("key.offset");
KeyLength = sourcekitd_uid_get_from_cstr("key.length");
KeyActionable = sourcekitd_uid_get_from_cstr("key.actionable");
KeyKind = sourcekitd_uid_get_from_cstr("key.kind");
KeyCodeCompleteOptions =
sourcekitd_uid_get_from_cstr("key.codecomplete.options");
Expand Down
1 change: 0 additions & 1 deletion utils/gyb_sourcekit_support/UIDs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,6 @@ def __init__(self, internal_name, external_name):
KEY('Names', 'key.names'),
KEY('UIDs', 'key.uids'),
KEY('SyntacticOnly', 'key.syntactic_only'),
KEY('Actionable', 'key.actionable'),
KEY('ParentLoc', 'key.parent_loc'),
KEY('IsTestCandidate', 'key.is_test_candidate'),
KEY('Overrides', 'key.overrides'),
Expand Down