Skip to content

Revert "Mandatory SIL linker pass" #15940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2018

Conversation

atrick
Copy link
Contributor

@atrick atrick commented Apr 14, 2018

Reverts #15930

PR 15930 was only smoke tested. It's been blocking full PR testing.

SIL verification failed: external declarations of SILFunctions with shared visibility is not allowed: SingleFunction || !hasSharedVisibility(RefF->getLinkage()) || RefF->hasForeignBody()

Verifying instruction:
-> // function_ref specialized FixedWidthInteger.init(truncatingIfNeeded:)
%928 = function_ref @$Ss17FixedWidthIntegerPsE18truncatingIfNeededxqd___tcs06BinaryC0Rd__lufCqd__s6UInt64VXMTA2FRszsADRd__r__lIetMiyd_Tpq5 : $@convention(method) <τ_0_0 where τ_0_0 == UInt64><τ_1_0 where τ_1_0 : BinaryInteger> (@in τ_1_0, @thick UInt64.Type) -> UInt64 // user: %929
%929 = apply %928(%926, %29) : $@convention(method) <τ_0_0 where τ_0_0 == UInt64><τ_1_0 where τ_1_0 : BinaryInteger> (@in τ_1_0, @thick UInt64.Type) -> UInt64 // user: %930

In function:
// globalinit_33_F417D752D2C4E9330E1C700411CE0C6A_func15
sil private @globalinit_33_F417D752D2C4E9330E1C700411CE0C6A_func15 : $@convention(c) () -> ()

Building Dispatch for WatchSimulator.

@atrick atrick requested a review from slavapestov April 14, 2018 23:43
@atrick
Copy link
Contributor Author

atrick commented Apr 14, 2018

@swift-ci test.

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 39de8c7

@atrick
Copy link
Contributor Author

atrick commented Apr 15, 2018

@swift-ci smoke test OS X Platform.

@atrick atrick merged commit d5c904b into master Apr 15, 2018
@atrick
Copy link
Contributor Author

atrick commented Apr 15, 2018

@slavapestov I'm reverting multiple PR's to try to get PR testing working again.

@atrick atrick deleted the revert-15930-mandatory-sil-linker-pass branch November 14, 2018 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants