IRGen: Outlining thunks don't need to receive fixed-size metadata #15972
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
slavapestov
force-pushed
the
fix-outlined-thunks
branch
from
ce3df8e to
a2c6f37
Compare
|
@swift-ci Please test |
|
@swift-ci Please test source compatibility |
|
Build failed |
|
Build failed |
slavapestov
changed the title
|
@DougGregor I'm not going to bother adding the test case unless the source compat suite passes, but it fixes that MyPrivate/OtherPrivate example you showed me. |
DougGregor
approved these changes
Apr 17, 2018
slavapestov
force-pushed
the
fix-outlined-thunks
branch
from
a2c6f37 to
9fb0248
Compare
They're not used inside the thunk so it's a waste passing them in, and if they involve private types from a different translation unit we will get a linking error from referencing the metadata accessor function. Fixes the test case in <rdar://problem/39470607>, but the more general problem remains.
slavapestov
force-pushed
the
fix-outlined-thunks
branch
from
9fb0248 to
39a65ab
Compare
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a general problem where if a public fixed-layout type contains internal or private fields, we have trouble manipulating values of the type from outside the module. This patch doesn't address the issue, but fixes one specific case where we don't need the metadata anyway.