SILCleanup => IRGenPrepare. #15973
Merged
SILCleanup => IRGenPrepare. #15973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ename it to IRGenPrepare. I am going to be adding logic here to enable swiftlang#1550 to be completed. The rename makes sense due to precedent from LLVM's codegen prepare and also since I am going to be expanding what the pass is doing beyond just "cleaning up". It is really a grab bag pass for performing simple transformations that we do not want to pollute IRGen's logic with. swiftlang#15502 rdar://39335800
…actually change something. rdar://39335800
|
@swift-ci smoke test |
|
This seems fine. The name is bit strange because one would expect something called IRGenPrepare to work on the form of SIL that IRGen actually sees (lowered). This is more of a SIL lowering (post-serialization) prepare. |
|
I called it IRGenPrepare since it is basically a misc place for transformations that happen in preparation for lowered IR. If you come up with a better name, I am happy to change it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
rdar://39335800
This is in preparation for #15502.