[stdlib] Add compatibility typealias for CountablePartialRangeFrom #15989
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
airspeedswift
force-pushed
the
countable-compat
branch
from
fa464f9 to
dfd2a76
Compare
airspeedswift
force-pushed
the
countable-compat
branch
from
dfd2a76 to
31c3b8b
Compare
|
@swift-ci please test |
stdlib/public/core/Range.swift
Outdated
|
|
||
| @available(*, deprecated: 4.2, renamed: "PartialRangeUpTo") | ||
| public typealias CountablePartialRangeUpTo<Bound: Strideable> = PartialRangeUpTo<Bound> | ||
| where Bound.Stride : SignedInteger |
There was a problem hiding this comment.
I don't think these two ever existed… It was just 5... that was countable, right?
There was a problem hiding this comment.
i.e. Just CountablePartialRangeFrom needs to be an alias.
There was a problem hiding this comment.
ohhhh right.... yeah, because that is the only one that can be a sequence cos it has a starting point.
That makes me slightly less embarrassed to have forgotten to do this.
|
@swift-ci please smoke test |
airspeedswift
changed the title
airspeedswift
added a commit
to airspeedswift/swift
that referenced
this pull request
Apr 17, 2018
airspeedswift
added a commit
that referenced
this pull request
Apr 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These type aliases for partial ranges were missed in the removal of
CountableRange