[AST] Initialize Target of break/continue with nullptr #16055
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, it's never initialized. This doesn't affect normal compilation because it doensn't reach only-user SILGen due to typecheck error. However, IDE refactoring uses this regardless of the error. rdar://problem/33972653
|
@swift-ci Please smoke test |
|
Not sure who should review this. @slavapestov or @jrose-apple ? |
jrose-apple
approved these changes
Apr 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, it's never initialized in error case. This doesn't affect normal compilation because it doensn't reach SILGen (the only user) due to typecheck error. However, IDE refactoring uses this regardless of the error.
rdar://problem/33972653