Skip to content

[AST] NFC: De-boilerplate the TypeMatcher #16062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 20, 2018
Merged

[AST] NFC: De-boilerplate the TypeMatcher #16062

merged 1 commit into from
Apr 20, 2018

Conversation

davezarzycki
Copy link
Contributor

This also future proofs the type matcher against new types being added to existing abstractions.

@davezarzycki
[AST] NFC: De-boilerplate the TypeMatcher
8a46a02 
This also future proofs the type matcher against new types being added
to existing abstractions.
@davezarzycki davezarzycki requested a review from DougGregor April 20, 2018 14:23
@davezarzycki
Copy link
Contributor Author

@swift-ci please smoke test

DougGregor
DougGregor approved these changes Apr 20, 2018
View reviewed changes
Copy link
Member

@DougGregor DougGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@davezarzycki davezarzycki merged commit 71e72d8 into swiftlang:master Apr 20, 2018
@davezarzycki davezarzycki deleted the nfc_simplify_TypeMatcher branch April 20, 2018 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DougGregor DougGregor DougGregor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davezarzycki @DougGregor