Skip to content

Simplify finalization of 'lazy' properties #16063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 20, 2018

Conversation

slavapestov
Copy link
Contributor

@slavapestov slavapestov commented Apr 20, 2018

Follow-up to #16053.

@slavapestov
Copy link
Contributor Author

@swift-ci Please test

@slavapestov
Copy link
Contributor Author

@swift-ci Please test source compatibility

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 5dfb601da483493444504bddd1f60e15a29bfc4e

We already do everything in typeCheckDecl(), so there's no need
to walk the members of the type again.
finalizeType() should only be called for types in other source files.
@slavapestov
Copy link
Contributor Author

@swift-ci Please smoke test

1 similar comment
@slavapestov
Copy link
Contributor Author

@swift-ci Please smoke test

@slavapestov
Copy link
Contributor Author

@swift-ci Please test source compatibility

@slavapestov
Copy link
Contributor Author

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 5dfb601da483493444504bddd1f60e15a29bfc4e

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 5dfb601da483493444504bddd1f60e15a29bfc4e

@slavapestov
Copy link
Contributor Author

@swift-ci Please test source compatibility

@slavapestov slavapestov merged commit e8a1524 into swiftlang:master Apr 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants