Applying API guidelines to The Standard Library #1607
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ft-3-omit-needless-words
…tension hash. We were verifying the Swift full version information from the module file extension metadata for the Swift name lookup tables, but not actually putting it in the hash, which meant that having an older module cache around would cause spurious failures when Swift name lookup tables were enabled. Instead, use just the major/minor version numbers of the lookup tables. When the lookup table format or contents of the lookup table change, we'll bump the version number.
And other API changes that naturally fall out from this, like Array(repeating:count:) => Array(repeating:length:).
It is not possible to call these functions by usual means.
We prefer 'nil' to be used instead.
…ft-3-api-guidelines
moiseev
added a commit
that referenced
this pull request
Mar 10, 2016
Applying API guidelines to The Standard Library
|
😍👏 |
|
🎉 |
|
🎉👏👍 |
|
👏 |
|
Amazing 🎊🎖 J. Charles
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applying swift API naming guidelines to The Standard Library
This PR applies the guidelines to The Standard Library according to this proposal.
Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
Validation Testing
Note: Only members of the Apple organization can trigger swift-ci.