Foundation: resolve some warnings #16078
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
|
It looks like none of these changes directly apply to swift-corelibs-foundation:
|
|
I can't speak to the KVO changes, but the JSON and String ones look good to me! |
|
Checked with David about the KVO change and he said it looks good. Merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JSONEncoder.swift: tell the compiler that yes, this is supposed to be casting to 'T' and not 'T?'.
NSObject.swift: mark NSKeyValueObservation members explicitly
@objcand@nonobjc.NSStringAPI.swift: remove unnecessary
@usableFromInline.No intended functionality change.