Skip to content

Revert "Disable test/stdlib/ErrorBridgedStatic.swift on no_asserts builds" #16101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2018

Conversation

airspeedswift
Copy link
Member

Reverts #16072

Doing this to see it fail to determine potential causes.

@airspeedswift
Copy link
Member Author

@swift-ci please test

@airspeedswift
Copy link
Member Author

Huh, ok. Guessing whatever originally caused this to fail was transient and since fixed.

@aschwaighofer
Copy link
Contributor

aschwaighofer commented Apr 24, 2018

This only failed on one bot (optimized+noasserts stdlib build): https://ci.swift.org/job/oss-swift_tools-R_stdlib-RD_test-simulator/1486/

I have since tried to reproduce this (several times actually, also ran the test under libgmalloc) on two of my machines using the swift/utils/build-script --preset=buildbot,tools=R,stdlib=RD install_destdir="${WORKSPACE}/install" installable_package="${SWIFT_INSTALLABLE_PACKAGE}" command and did not succeed.

However, I did seem to reliably fail on the bot.

But lets give this a shot again.

@aschwaighofer aschwaighofer merged commit 0799683 into master Apr 24, 2018
@aschwaighofer
Copy link
Contributor

This successful build had the revert in it: https://ci.swift.org/job/oss-swift_tools-R_stdlib-RD_test-simulator/1503/

@shahmishal shahmishal deleted the revert-16072-disable_failing_test branch May 13, 2022 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants