Instead of crashing for bad output-file-map path, exit. Also print the path in the diagnostic. rdar://39660680 #16126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
…e path in the diagnostic.
|
@swift-ci please smoke test |
davidungar
force-pushed
the
exit-dont-crash-for-missing-output-file-map
branch
from
2d4179b to
2b89d1c
Compare
|
Tx! |
davidungar
changed the title
davidungar
pushed a commit
to davidungar/swift
that referenced
this pull request
Apr 26, 2018
…r-missing-output-file-map Instead of crashing for bad output-file-map path, exit. Also print the path in the diagnostic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug in the driver that caused a crash if passed a bad path for -output-file-map. Also add the path to the diagnostic. Add a test.