[SwiftSyntax] Simplify AbsolutePosition offset calculation and support columns #16131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harlanhaskins
commented
Apr 24, 2018
| /// Specifically, walks through the trivia and keeps track of every newline | ||
| /// to give a number of how many newlines and UTF8 characters appear in the | ||
| /// trivia, along with the UTF8 offset of the last column. | ||
| func characterSizes() -> (lines: Int, lastColumn: Int, utf8Length: Int) { |
There was a problem hiding this comment.
Surprisingly, this code was never called.
|
@nkcsgexi I'm wondering if we even need the utf-16 encoding. |
|
@harlanhaskins if we have the character offset, then we don't need utf16-based offset i presume. The idea is utf16-based offset is easier to bridge to character offset. |
|
The calculation is a little bit wrong, I'm investigating now. |
harlanhaskins
commented
Apr 24, 2018
| } | ||
|
|
||
| internal func add(columns: Int) { | ||
| print("adding \(columns) column bytes") |
There was a problem hiding this comment.
Will remove before merging
|
Wow, very simple bug. @swift-ci please smoke test |
harlanhaskins
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch simplifies the calculation and structure of AbsolutePosition, in preparation for DiagnosticEngine changes to easily create SourceLocations.