IRGen: We need to make not of any parent decl in nested type decls #16135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Such that we emit the parent's type metadata rdar://39648725
|
@swift-ci Please test |
aschwaighofer
added a commit
to aschwaighofer/swift
that referenced
this pull request
Apr 24, 2018
…ecls Such that we emit the parent's type metadata rdar://39648725 Cherry-pick from swiftlang#16135
aschwaighofer
added a commit
to aschwaighofer/swift
that referenced
this pull request
Apr 24, 2018
…ecls Such that we emit the parent's type metadata rdar://39648725 Cherry-pick from swiftlang#16135
slavapestov
reviewed
Apr 24, 2018
lib/IRGen/GenMeta.cpp
Outdated
| void IRGenerator::noteUseOfAnyParentTypeMetadata(NominalTypeDecl *type) { | ||
| // If this is a nested type we also potentially might need the outer types. | ||
| auto *declCtxt = type->getDeclContext(); | ||
| assert(declCtxt); |
There was a problem hiding this comment.
This assertion is not needed. The type will never be null, and if it is, you will crash below.
slavapestov
reviewed
Apr 24, 2018
lib/IRGen/GenMeta.cpp
Outdated
| // If this is a nested type we also potentially might need the outer types. | ||
| auto *declCtxt = type->getDeclContext(); | ||
| assert(declCtxt); | ||
| auto *parentNominalDecl = dyn_cast_or_null<NominalTypeDecl>(declCtxt); |
There was a problem hiding this comment.
On the other hand, this will fail if the type is defined inside an extension. Instead, use declCtxt->getAsNominalTypeOrNominalTypeExtensionContext().
slavapestov
reviewed
Apr 24, 2018
| } | ||
| } | ||
|
|
||
| struct Outer3 { |
There was a problem hiding this comment.
Please add some tests involving extensions.
rdar://39648725
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Such that we emit the parent's type metadata
rdar://39648725