[SwiftSyntax] Add accessors for source locations and test diagnostic emission #16141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkcsgexi
reviewed
Apr 25, 2018
| } | ||
| override func visit(_ function: FunctionDeclSyntax) { | ||
| let startLoc = function.identifier.startLocation(in: url) | ||
| engine.diagnose(.badFunction(function.identifier), location: startLoc) { |
There was a problem hiding this comment.
can we issue diags to the end of the function decl to test the end location too?
|
@swift-ci please smoke test |
nkcsgexi
approved these changes
Apr 25, 2018
|
Mutation strikes again. @swift-ci please smoke test |
maldahleh
pushed a commit
to maldahleh/swift
that referenced
this pull request
Oct 26, 2020
…emission (swiftlang#16141) * [SwiftSyntax] Add accessors for source locations and test diagnostic emission * Add tests for endLocation * Pre-emptively copy AbsolutePosition to avoid mutating it twice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds accessors on
SyntaxforstartLocation,endLocation, andsourceRange. They have to take a file URL, because the Syntax tree is independent of a file.Also add a test in the DiagnosticTest that gets the source locations of a file.