[libSyntax] Parsing fixes for #if, trailing semicolon, key paths #16155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
nkcsgexi
reviewed
Apr 25, 2018
lib/Parse/ParseDecl.cpp
Outdated
| SyntaxParsingContext DeclContext(SyntaxContext, | ||
| SyntaxKind::MemberDeclListItem); | ||
| { | ||
| SyntaxParsingContext DeclContext(SyntaxContext, SyntaxContextKind::Decl); |
There was a problem hiding this comment.
Do we need this context? it seems parseDecl has its own parsing context in scope.
ahoppen
force-pushed
the
if-semi-keypath
branch
from
62e45d6 to
1781e6b
Compare
|
@swift-ci Please smoke test |
ahoppen
force-pushed
the
if-semi-keypath
branch
from
1781e6b to
94b8a35
Compare
|
@swift-ci Please smoke test |
abl
pushed a commit
to abl/swift
that referenced
this pull request
May 4, 2018
A recent change to SwiftSyntax broke our build: swiftlang#16155 PiperOrigin-RevId: 194541217
allevato
pushed a commit
to google/swift
that referenced
this pull request
Sep 17, 2018
A recent change to SwiftSyntax broke our build: swiftlang#16155 PiperOrigin-RevId: 194541217
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides three minor parsing fixes for libSyntax:
#ifinside type declarations (e.g. members that are only present conditionally)