libSyntax: add a mechanism to synthesize syntax nodes in SyntaxParsingContext. #16158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
|
LGTM I'm just thinking we might want to disallow passing missing nodes to non-optional children in the factory methods so that users can't create invalid syntax trees. |
|
@ahoppen hmm, i think there's no problem to allow users to create syntax nodes with missing children. Since parser wants to do this any way to keep the tree as meaningful as it can. |
rintaro
approved these changes
Apr 26, 2018
|
|
||
| // Function body without closing brace token. | ||
| func foo() { | ||
| var a = 2 |
There was a problem hiding this comment.
Could you add newline at the end? Test for preserving trivia for EOF is important here.
…gContext. To enhance the error-recovery of syntax parsing, this patch allows the parser to synthesize missing nodes to satisfy the requirement of a syntax node under parsing. As proof-of-concept, we synthesize r-braces for function body to avoid regressing a function decl to an unknown decl.
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To enhance the error-recovery of syntax parsing, this patch allows the
parser to synthesize missing nodes to satisfy the requirement of a
syntax node under parsing. As proof-of-concept, we synthesize r-braces
for function body to avoid regressing a function decl to an unknown
decl.