[build-script] XCTest xcodebuild uses SWIFT_EXEC #1620
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because the `xcodebuild` invocation used to compile swift-corelibs-xctest on OS X uses a toolchain that is usually out of date, it often fails (for example, when building the newly migrated Swift 3 code). Pass the path to the freshly built `swiftc` to `xcodebuild` in order to use the latest Swift compiler.
|
@shahmishal Would it be possible to trigger the "buildbot_incremental,tools=RA,stdlib=RA,XCTest" preset on OS X and Linux with these changes? I'd like to see if it gets tests passing. |
|
@swift-ci Please test |
|
The Linux |
|
@modocache Yes, lets test |
|
@swift-ci Please test |
tkremenek
added a commit
that referenced
this pull request
Mar 12, 2016
…ift-exec [build-script] XCTest xcodebuild uses SWIFT_EXEC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
Because the
xcodebuildinvocation used to compile swift-corelibs-xctest on OS X uses a toolchain that is usually out of date, it often fails (for example, when building the newly migrated Swift 3 code).Pass the path to the freshly built
swiftctoxcodebuildin order to use the latest Swift compiler. This should allow the swift-corelibs-xctest OS X CI to pass.Resolved bug number: None
Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
Validation Testing
Note: Only members of the Apple organization can trigger swift-ci.