[Clang importer] Honor swift_bridged_typedef attribute. #16229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the swift_bridged_typedef attribute is present on a typedef, import the underlying type as bridged (e.g., String) rather than as its unbridged type (e.g., NSString). Fixes rdar://problem/39497900.
|
@swift-ci please smoke test and merge |
|
Bah, the Clang automerge didn't happen yet. |
|
@swift-ci please smoke test |
jrose-apple
reviewed
Apr 30, 2018
| importedType = hint.BridgedType; | ||
|
|
||
| // Set the bridged type if it wasn't done already. | ||
| if (!importedType->isEqual(hint.BridgedType)) |
There was a problem hiding this comment.
Why do we need this check?
There was a problem hiding this comment.
hint.BridgedType might be a sugared version of importedType, in which case we want to keep that sugar.
| static inline Bridgeability getTypedefBridgeability(clang::QualType type) { | ||
| return type->isBlockPointerType() ? Bridgeability::Full : Bridgeability::None; | ||
| static inline Bridgeability getTypedefBridgeability( | ||
| const clang::TypedefNameDecl *decl, |
There was a problem hiding this comment.
Nitpick: LLVM style prefers double-indenting here rather than max-indenting.
| @import Foundation; | ||
|
|
||
|
|
||
| typedef NSString *NSMyAmazingStringAlias __attribute__((swift_bridged_typedef)); |
There was a problem hiding this comment.
Can you test a typedef that uses this typedef as well? If that typedef doesn't have the swift_bridged_typedef attribute, what behavior should it have?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
swift_bridged_typedefattribute is present on a typedef,import the underlying type as bridged (e.g., String) rather than as
its unbridged type (e.g., NSString).
Fixes rdar://problem/39497900.