[stdlib] De-gyb Arrays.swift.gyb #16230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
gottesmm
requested changes
Apr 28, 2018
stdlib/public/core/ArrayShared.swift
Outdated
| @@ -0,0 +1,375 @@ | |||
| //===--- Arrays.swift.gyb -------------------------------------*- swift -*-===// | |||
| @@ -0,0 +1,407 @@ | |||
| // ###sourceLocation(file: "/Users/lanceparker/Development/swift-source/swift/stdlib/public/core/Arrays.swift.gyb", line: 1) | |||
There was a problem hiding this comment.
Bad title and ### source location. You should probably grep for these.
gottesmm
approved these changes
Apr 28, 2018
|
(sorry I just meant to leave comments, not approve/disapprove) |
|
@swift-ci please test |
added 7 commits
May 30, 2018 10:49
|
@swift-ci please test |
|
Build failed |
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split up Array, ArraySlice and ContiguousArray into one file each, with an ArrayShared file for common stuff.