Start gutting ExprCleaner and friends #16234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead, generate the type variable in ConstraintGenerator. However, we only want to generate it if we're type checking from inside TypeChecker::typeCheckCompletionSequence(), so add an isActivated() flag to CodeCompletionExpr. If it is not set, constraint generation will simply fail on an expression containing a CodeCompletionExpr.
slavapestov
force-pushed
the
start-gutting-expr-cleaner-crap
branch
2 times, most recently
from
7624ca4 to
9c6477e
Compare
…es not TypeLocs Most callers were using TypeLoc::withoutLoc() to wrap a Type, and the one place that still had TypeReprs can resolve the TypeReprs right there instead.
slavapestov
force-pushed
the
start-gutting-expr-cleaner-crap
branch
from
9c6477e to
c89a4a5
Compare
|
@swift-ci Please smoke test |
|
Cool, thanks! @xedin took care of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @rudkx's work on the constraint system type map, we can actually enforce that Exprs don't get type variables stored into them.