Run more function passes in a single run of the pass manager. #1627
+5
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit moves the SILLinker pass out of AddSSAPasses, so that we run more function passes on each function before moving up to it's callers. Now the only remaining module passes in AddSSAPasses are GlobalOpt and LetPropertiesOpt, which run only when we call AddSSAPasses for the MidLevel optimizations. This commit also adds the high level loop opt passes onto the same pass run. As a result of this and moving SILLinker out of AddSSAPasses, we now run far more passes together on a given function before moving up the call graph to the callers. The net result is that I am now seeing approximately a 2% reduction in stdlib compile times, with only a single significant performance regression (there are some other minor improvements and regressions, and some major improvements with -Ounchecked). The 2% reduction appears to come largely from the mechanism in the pass manager that skips running passes if we've not made any changes to a function since the last time the pass was run.
|
@swift-ci Please test |
|
It looks like OS X testing is failing on someone else's change. |
|
@swift-ci Please test OS X platform |
rudkx
added a commit
that referenced
this pull request
Mar 11, 2016
Run more function passes in a single run of the pass manager.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
An improvement to the pass pipeline that reduces execution time while potentially improving generated code.
Resolved bug number: (SR-)
Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
Validation Testing
Note: Only members of the Apple organization can trigger swift-ci.
This commit moves the SILLinker pass out of AddSSAPasses, so that we run
more function passes on each function before moving up to it's callers.
Now the only remaining module passes in AddSSAPasses are GlobalOpt and
LetPropertiesOpt, which run only when we call AddSSAPasses for the
MidLevel optimizations.
This commit also adds the high level loop opt passes onto the same pass
run. As a result of this and moving SILLinker out of AddSSAPasses, we
now run far more passes together on a given function before moving up
the call graph to the callers.
The net result is that I am now seeing approximately a 2% reduction in
stdlib compile times, with only a single significant performance
regression (there are some other minor improvements and regressions, and
some major improvements with -Ounchecked).
The 2% reduction appears to come largely from the mechanism in the pass
manager that skips running passes if we've not made any changes to a
function since the last time the pass was run.