ClangImporter: improve ObjC-interop and enable tests #16275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrose-apple
reviewed
May 1, 2018
| @@ -1,9 +1,8 @@ | |||
| // RUN: %empty-directory(%t) | |||
| // RUN: not %target-swift-frontend -typecheck %s -I %S/Inputs/non-modular -F %S/Inputs/non-modular 2>&1 | %FileCheck --check-prefix=CHECK --check-prefix=CHECK-%target-runtime %s | |||
| // RUN: not %target-swift-frontend -enable-objc-interop -typecheck %s -I %S/Inputs/non-modular -F %S/Inputs/non-modular 2>&1 | %FileCheck --check-prefix=CHECK %s | |||
There was a problem hiding this comment.
Please don't change this test; we want to check both error messages. Or add a test with -disable-objc-interop instead.
There was a problem hiding this comment.
Sure, I'll add a second test case :-). We can test both paths on all targets now.
compnerd
force-pushed
the
clang-importer
branch
2 times, most recently
from
4f7a3f2 to
5915fdf
Compare
|
@swift-ci please test |
|
Build failed |
|
Build failed |
This enables additional tests for the ClangImporter. This found a missing piece in the `-enable-objc-interop` work that was done previously. Address that and enable the tests. There are now the following failing tests on Linux: * sdk - depends on Foundation (not hermetic, see SR-7572) * mixed-nsuinteger - depends on Foundation (not hermetic, see SR-7572) * import-mixed-with-header-twice - requires apple/swift PR#16022 * can_import_objc_idempotent - requires apple/swift PR#16022 * objc_protocol_renaming - requires apple/swift PR#16022
|
@swift-ci please test |
|
Build failed |
|
@swift-ci please test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables additional tests for the ClangImporter. This found a
missing piece in the
-enable-objc-interopwork that was donepreviously. Address that and enable the tests. There are now two
failing tests on Linux:
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.