Skip to content

[Lexer][QoI] Diagnose and fix-it consecutive 'U+00A0's at once #16280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 2, 2018
Merged

[Lexer][QoI] Diagnose and fix-it consecutive 'U+00A0's at once #16280

merged 1 commit into from
May 2, 2018

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented May 1, 2018

Small improvement for #16090

@rintaro
Copy link
Member Author

rintaro commented May 1, 2018

@swift-ci Please smoke test

@rintaro rintaro requested a review from jrose-apple May 1, 2018 13:01
@jrose-apple
Copy link
Contributor

Seems reasonable to me. @hashemi, any comments?

@hashemi
Copy link
Contributor

hashemi commented May 1, 2018

Yes, this makes a lot of sense (and is very helpful for my learning to see) 👍

@rintaro rintaro merged commit 2d63803 into swiftlang:master May 2, 2018
@rintaro
Copy link
Member Author

rintaro commented May 2, 2018

Thanks!

@rintaro rintaro deleted the lexer-nbsp-consecutive branch May 2, 2018 10:24
@rintaro rintaro mentioned this pull request May 2, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrose-apple jrose-apple jrose-apple approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rintaro @jrose-apple @hashemi