Skip to content

[Runtime] Fix warnings for inconsistent nullability annotation on _stdlib_getEnviron. #16281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 10, 2018
Merged

[Runtime] Fix warnings for inconsistent nullability annotation on _stdlib_getEnviron. #16281

merged 1 commit into from
May 10, 2018

Conversation

mikeash
Copy link
Contributor

@mikeash mikeash commented May 1, 2018

rdar://problem/39739801

@mikeash mikeash requested a review from rjmccall May 1, 2018 17:43
@mikeash
Copy link
Contributor Author

mikeash commented May 1, 2018

@swift-ci please test

@compnerd
Copy link
Member

compnerd commented May 1, 2018 •
edited
Loading

#13254 is related to this. @jrose-apple and I discussed this on the original PR, and fixing that seemed to uncover something which needed to go through evolution :-(.

@mikeash
Copy link
Contributor Author

mikeash commented May 1, 2018

Yikes, that's more complicated than I realized. Would it be reasonable to specify _Null_unspecified to silence the warnings for now? That will avoid breaking things, although it's yucky.

@jrose-apple
Copy link
Contributor

I'm in favor of _Null_unspecified as well.

@mikeash
Copy link
Contributor Author

mikeash commented May 1, 2018

Given that there seems to be disagreement (between standard and implementation, not just between us!) over whether it is in fact nullable, _Null_unspecified actually seems like an accurate annotation for once.

@rjmccall
Copy link
Contributor

rjmccall commented May 1, 2018

The TupleCacheEntry change is fine, but I don't know why it's part of the same PR here?

@mikeash
Copy link
Contributor Author

mikeash commented May 9, 2018

@rjmccall No good reason! I'm going to separate that into another PR now.

@mikeash mikeash force-pushed the warning-fix-libcshims-metadata branch from 871094a to 022253e Compare May 9, 2018 17:46
@mikeash
Copy link
Contributor Author

mikeash commented May 9, 2018

Switched to _Null_unspecified and cut out the unrelated offsetof fix.

@mikeash
Copy link
Contributor Author

mikeash commented May 9, 2018

@swift-ci please smoke test

@mikeash mikeash changed the title [Runtime] Fix warnings for inconsistent nullability annotation on _stdlib_getEnviron and offsetof usage on TupelCacheEntry. [Runtime] Fix warnings for inconsistent nullability annotation on _stdlib_getEnviron. May 9, 2018
@compnerd
Copy link
Member

@swift-ci please smoke test

@mikeash mikeash merged commit 0a6ea97 into swiftlang:master May 10, 2018
@mikeash mikeash mentioned this pull request May 11, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjmccall rjmccall Awaiting requested review from rjmccall

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mikeash @compnerd @jrose-apple @rjmccall