Revert "'@available' without an OS is ignored on extensions" warning #16298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
This is still useful for the feature where deprecated declarations are allowed to be used within a context that's marked deprecated. There's probably a better balance to be found here, because marking the extension deprecated still does not mark all the members deprecated, but for now it still has an effect, and we shouldn't produce a warning for legitimately making use of that effect. The warning was added in f21d9f3, mostly as an opportunity "fix". https://bugs.swift.org/browse/SR-7577
jrose-apple
force-pushed
the
i-wont-warn-you-again
branch
from
f00efa2 to
40c8975
Compare
|
@swift-ci Please smoke test |
huonw
approved these changes
May 2, 2018
jrose-apple
added a commit
to jrose-apple/swift
that referenced
this pull request
May 3, 2018
…wiftlang#16298) This is still useful for the feature where deprecated declarations are allowed to be used within a context that's marked deprecated. There's probably a better balance to be found here, because marking the extension deprecated still does not mark all the members deprecated, but for now it still has an effect, and we shouldn't produce a warning for legitimately making use of that effect. The warning was added in f21d9f3, mostly as an opportunity "fix". https://bugs.swift.org/browse/SR-7577 (cherry picked from commit 23260b8)
jrose-apple
added a commit
to jrose-apple/swift
that referenced
this pull request
May 3, 2018
…wiftlang#16298) This is still useful for the feature where deprecated declarations are allowed to be used within a context that's marked deprecated. There's probably a better balance to be found here, because marking the extension deprecated still does not mark all the members deprecated, but for now it still has an effect, and we shouldn't produce a warning for legitimately making use of that effect. The warning was added in f21d9f3, mostly as an opportunity "fix". https://bugs.swift.org/browse/SR-7577 (cherry picked from commit 23260b8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still useful for the feature where deprecated declarations are allowed to be used within a context that's marked deprecated. There's probably a better balance to be found here, because marking the extension deprecated still does not mark all the members deprecated, but for now it still has an effect, and we shouldn't produce a warning for legitimately making use of that effect.
The warning was added in #15213, mostly as an opportunity "fix".
SR-7577 / rdar://problem/39867773