[stdlib] Fix type of _swift_stdlib_HashingDetail_fixedSeedOverride #1631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GlobalObjects.h declares it as __swift_uint64_t, but GlobalObjects.cpp declared it as uint64_t. The types should match exactly.
|
Why should the spellings match? The expansion of the type matches already. If it does not, that's a problem that needs to be fixed. |
|
@gribozavr Isn't it just general good code hygiene for the spellings to match? |
|
@swift-ci Please test |
tkremenek
added a commit
that referenced
this pull request
Mar 16, 2016
[stdlib] Fix type of _swift_stdlib_HashingDetail_fixedSeedOverride
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed type of _swift_stdlib_HashingDetail_fixedSeedOverride definition to __swift_uint64_t to match extern declaration in header.
GlobalObjects.h declares it as __swift_uint64_t, but GlobalObjects.cpp declared
it as uint64_t. The types should match exactly.
Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
Validation Testing
Note: Only members of the Apple organization can trigger swift-ci.