[4.2 4/30][Sema] SpaceEngine: Improve handling of empty/non-reduced spaces in c… #16316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onstrutors/disjuncts Eagerly remove empty (sub-)spaces from constructors and disjuncts to minimize number of operations required to check space coverage. Also return original constructor space while subtracting a pair of constructors, instead of disjunct, if subtraction of one of its sub-spaces produced the same space, this reduces the number of disjuncts in the path. Resolves: rdar://problem/39710335 (cherry picked from commit 3ea6635)
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
|
@AnnaZaks It looks like there are couple of issues in the source compatibility suite for this branch (swift-4.2-branch-04-30-2018) which are unrelated to these changes e.g. broken dependency in Kitura. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…onstrutors/disjuncts
Eagerly remove empty (sub-)spaces from constructors and disjuncts
to minimize number of operations required to check space coverage.
Also return original constructor space while subtracting a pair of
constructors, instead of disjunct, if subtraction of one of its
sub-spaces produced the same space, this reduces the number of
disjuncts in the path.
Resolves: rdar://problem/39710335
(cherry picked from commit 3ea6635)