Sema: Infer '@_usableFromInline' imports by looking at references from inlinable functions #16326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m inlinable functions Completes the fix for <rdar://problem/39338239>.
|
@swift-ci Please smoke test |
|
I already reviewed this back in #16299, so this is mostly cursory. Will run more rigorous tests when cherry-picking to 4.2. |
jrose-apple
added a commit
to jrose-apple/swift
that referenced
this pull request
May 3, 2018
…m inlinable functions (swiftlang#16326) Basic fix for <rdar://problem/39338239>, but there are still some more cases we haven't handled yet. (cherry picked from commit ee6e190)
jrose-apple
added a commit
to jrose-apple/swift
that referenced
this pull request
May 3, 2018
…m inlinable functions (swiftlang#16326) Basic fix for <rdar://problem/39338239>, but there are still some more cases we haven't handled yet. (cherry picked from commit ee6e190)
jrose-apple
added a commit
to jrose-apple/swift
that referenced
this pull request
May 4, 2018
…nces from inlinable functions (swiftlang#16326)" This reverts commit ee6e190. It's not sufficient to solve the problem, and the choices were to do something more complicated, or just take a simple brute force approach. We're going with the latter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #16299 and #16317 are turning out to be tricky, let's get the incomplete fix in to at least cut down the number of people affected by this. Hopefully the rest of the fix will come soon.
rdar://problem/39338239