fix tests for FileCheck behaviour (DAG edition) #1634
Conversation
|
@benlangmuir one of the tests seem to have been passing silently because what it was checking for was not being checked, opinions on that? Theres a small issue with the patch as it stands which I will fix (I messed up the rebase), but I don't think that the issue in |
| @@ -9,7 +9,9 @@ | |||
| // RUN: %target-swift-ide-test -code-completion -source-filename %s -code-completion-token=DEFAULT_ARGS_6 | FileCheck %s -check-prefix=DEFAULT_ARGS_6 | |||
| // RUN: %target-swift-ide-test -code-completion -source-filename %s -code-completion-token=DEFAULT_ARGS_7 | FileCheck %s -check-prefix=DEFAULT_ARGS_7 | |||
| // RUN: %target-swift-ide-test -code-completion -source-filename %s -code-completion-token=DEFAULT_ARGS_8 | FileCheck %s -check-prefix=DEFAULT_ARGS_8 | |||
| // RUN: %target-swift-ide-test -code-completion -source-filename %s -code-completion-token=DEFAULT_ARGS_8 | FileCheck %s -check-prefix=NEGATIVE_DEFAULT_ARGS_8 | |||
There was a problem hiding this comment.
Instead of running swift-ide-test twice, please redirect it to a file and just run FileCheck twice.
|
Hmm, not sure without seeing how it fails. For now, could you bring back the failing lines, disable them and add a FIXME: comment? I can look into what's going wrong. |
|
Sure, the lines just show up. Ill add them with a FIXME though. |
|
Updated with the FIXME and disabled tests and the merge issue. |
|
Great idea, the FileCheck run is much cheaper. Updated to use temp files. |
|
@swift-ci Please test |
|
Ah, in |
|
Third times a charm, right? I hope. |
|
@swift-ci Please test |
|
complete_underscores.swift:51:30: I'm not sure why we didn't see the first time.. I guess another FIXME. |
|
Weird, Ill upload a patch later tonight (or worst case sometime tomorrow). |
|
Thanks for continuing to push on this 👍 |
|
Glad to be of help :-). The test failure was due to a bad conversion of the negative test case, sorry about that. I honestly don't know why I didn't see that failure locally. |
|
@swift-ci Please test |
FileCheck does not support the combination negation. These tests were incorrect and silently passing rather than checking what they intended.
|
Oops, forgot to add the last version of it I believe. There were three tests, and I only had committed the fix for one of them. |
|
@swift-ci Please test |
|
The failure is the same on both (swift-type-transformation crasher), and seems unrelated to the change itself to me. |
|
Let's try it for real then :-) |
fix tests for FileCheck behaviour (DAG edition)
[WASM] Update assertion condition for keypath projector
What's in this pull request?
Resolved bug number: (SR-)
Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
Validation Testing
Note: Only members of the Apple organization can trigger swift-ci.
FileCheck does not support the combination negation. These tests were incorrect
and silently passing rather than checking what they intended.