SILGen Tests #16347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

compnerd merged 5 commits into swiftlang:master from compnerd:silgen

Jun 11, 2018

Member

compnerd commented May 3, 2018

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

Member Author

compnerd commented May 3, 2018

@swift-ci please test

Contributor

swift-ci commented May 3, 2018

Build failed
Swift Test Linux Platform
Git Sha - 0e194a942692f402c8f458a10bbf6fc892962852

Contributor

swift-ci commented May 3, 2018

Build failed
Swift Test OS X Platform
Git Sha - 0e194a942692f402c8f458a10bbf6fc892962852

compnerd force-pushed the silgen branch from 0e194a9 to b246040 Compare

May 12, 2018 05:00

Member Author

compnerd commented May 12, 2018

@swift-ci please test

compnerd force-pushed the silgen branch from b246040 to 868c802 Compare

May 12, 2018 05:03

Member Author

compnerd commented May 12, 2018

@swift-ci please test

Contributor

swift-ci commented May 12, 2018

Build failed
Swift Test OS X Platform
Git Sha - b246040e73a6d619d228fdafa7e1029feec0dffe

Contributor

swift-ci commented May 12, 2018

Build failed
Swift Test Linux Platform
Git Sha - b246040e73a6d619d228fdafa7e1029feec0dffe

Member Author

compnerd commented May 13, 2018

CC: @aschwaighofer @jrose-apple suggestions as to why there are differences between the platforms here?

jrose-apple reviewed

View reviewed changes

Contributor

jrose-apple left a comment •

edited

Loading

My guess is always that you ended up using the mock SDK with the real overlays. Don't forget that the fake overlays have to be built and put into the search path!

test/SILGen/Inputs/usr/include/CoreData.h Outdated

    
            @@ -0,0 +1,12 @@
          
              @interface NSEntityDescription

Contributor

jrose-apple May 14, 2018

Probably best to import Foundation and inherit from NSObject too. Things unexpectedly being base classes does weird things in Objective-C.

Member Author

compnerd commented May 15, 2018

@swift-ci please smoke test macOS platform

compnerd force-pushed the silgen branch from 868c802 to 86e139b Compare

May 29, 2018 18:26

Member Author

compnerd commented May 29, 2018

@swift-ci please smoke test macOS platform

Member Author

compnerd commented May 29, 2018

Darwin Failing Tests:

Swift(macosx-x86_64).SILGen.without_actually_escaping_block.swift
Swift(macosx-x86_64).SILGen.metatype_in_init_delegation.swift
Swift(macosx-x86_64).SILGen.objc_bridging.swift
Swift(macosx-x86_64).IRGen.newtype.swift
Swift(macosx-x86_64).IDE.newtype.swift

compnerd force-pushed the silgen branch from 86e139b to 0055c15 Compare

June 8, 2018 16:19

Member Author

compnerd commented Jun 8, 2018

@swift-ci please smoke test macOS platform

compnerd force-pushed the silgen branch from 0055c15 to 80efe48 Compare

June 8, 2018 16:22

Member Author

compnerd commented Jun 8, 2018

@swift-ci please smoke test macOS platform

compnerd force-pushed the silgen branch from 80efe48 to 526d384 Compare

June 8, 2018 18:38

Member Author

compnerd commented Jun 8, 2018

@swift-ci please smoke test macOS platform

compnerd force-pushed the silgen branch from 526d384 to daf66ee Compare

June 8, 2018 21:27

Member Author

compnerd commented Jun 8, 2018

@swift-ci please smoke test

compnerd added 5 commits

June 11, 2018 09:23


          Inputs: sprinkle _Null_unspecified to silence nullability-completness

bc27395

When trying to figure out errors from an import failure, the nullability
completeness warnings would clutter the output making it difficult to
identify the errors.  Sprinkle the declaarations with
`_Null_unspecified` to maintain the current nullability semantics and
silence the warnings.  NFC.


          SILGen: remove duplicated module declaration

ebaf0b6

This module was specified in the IDE and SILGen testing module maps,
which causes a failure.  Remove the duplicated declaration in the
SILGen inputs and use IDE's definition.


          SILGen: flesh out Foundation stubs further

61c5346

The local bridging headers needed two new definitions:
  - NSErrorDomain
  - NS_OPTIONS

These can be used by the SILGen tests to build against a stubbed
Foundation rather than requiring the host to provide it.


          SILGen: stub out CoreData

a330db6

One of the SILGen tests uses CoreData.  Provide a stubbed out definition
sufficient for the tests.


          SILGen: enable additional tests globally

8b21fde

Enable a number of SILGen tests to run on all targets.  This improves
coverage on non-Darwin targets.

compnerd force-pushed the silgen branch from daf66ee to 8b21fde Compare

June 11, 2018 16:24

Member Author

compnerd commented Jun 11, 2018

@swift-ci please smoke test

compnerd merged commit 5e2d66a into swiftlang:master

compnerd deleted the silgen branch

June 11, 2018 17:17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet