Test for exhaustiveness cut-off. #16395
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidungar
force-pushed
the
adding-switch-cutoff-test
branch
from
ae09ac2 to
757dcf0
Compare
|
@swift-ci please smoke test |
jrose-apple
approved these changes
May 4, 2018
| // LIMIT: error: the compiler is unable to check that this switch is exhaustive in reasonable time | ||
| // LIMIT-NOT: error: switch must be exhaustive | ||
| // NO_LIMIT: error: switch must be exhaustive | ||
| // NO_LIMIT-NOT: error: the compiler is unable to check that this switch is exhaustive in reasonable time |
There was a problem hiding this comment.
This looks fine, but it's worth pointing out that -NOT lines only check that certain text does not appear after the previous positive check and before the next positive check. You could either bracket your LIMIT/NO_LIMIT lines with the -NOT checks, or save the error output to a file and check it twice (a common enough idiom in our test suite, look for -check-prefix NEGATIVE), or just not worry too much about it.
There was a problem hiding this comment.
Do you want to review the revised test?
|
@swift-ci please smoke test |
davidungar
force-pushed
the
adding-switch-cutoff-test
branch
from
73028cf to
ea749c2
Compare
|
@swift-ci please smoke test |
jrose-apple
approved these changes
May 5, 2018
|
Thanks, Jordan. |
davidungar
changed the title
This was referenced May 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a test for the recently-added -switch-checking-invocation-threshold= frontend option.