[SIL] Teach *ApplyInst to traffic in SubstitutionMap. #16400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DougGregor
force-pushed
the
sil-apply-substitution-map
branch
2 times, most recently
from
be1c07c to
2e07c7b
Compare
|
I've (again) hit a steady state where things build with this change, so let's see how it performs. |
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
|
@swift-ci please smoke test compiler performance |
|
@swift-ci please benchmark |
|
Build failed |
|
@swift-ci please test compiler performance |
Build comment file:Optimized (O)Regression (1)
Improvement (1)
No Changes (425)
Unoptimized (Onone)Regression (5)
Improvement (10)
No Changes (412)
Hardware Overview |
Build comment file:Summary for master fullUnexpected test results, excluded stats for ProcedureKit, StencilSwiftKit, ObjectMapper, Core Regressions found (see below) Debug-batchdebug-batch briefRegressed (0)
Improved (0)
Unchanged (delta < 1.0% or delta < 100.0ms) (2)
debug-batch detailedRegressed (2)
Improved (0)
Unchanged (delta < 1.0% or delta < 100.0ms) (71)
Releaserelease briefRegressed (0)
Improved (0)
Unchanged (delta < 1.0% or delta < 100.0ms) (2)
release detailedRegressed (0)
Improved (1)
Unchanged (delta < 1.0% or delta < 100.0ms) (22)
|
Push SubstitutionMaps through most of SILGen and the SIL optimizers that involve the various *ApplyInsts.
…ters. SubstitutionMap::lookupSubstitution() assumed that any type parameter it was given would already be canonical, and fail (return a null Type) when given a type parameter that was equivalent to another type parameter but is not itself canonical. Canonicalize, recursive, and record the replacement type appropriately.
Introduce an operation to check that a given substitution map is non-empty (i.e., corresponds to a generic signature) and that the generic signature has type parameters that aren’t bound to concrete types. This is the appropriate predicate for SIL-and-later to determine whether there will be any substitutions.
…nMap. SIL printing and parsing was based on printing substitution lists. Change that to instead print/parse based on the replacement types in substitution maps, which fits more closely with the rest of the system. This commit is papering over an issue where the substitution maps generated for the “apply” of a partial specialization use an ever-so-slightly different generic signature than partial specialization itself. The TODO in the SIL printer for covers that case.
DougGregor
force-pushed
the
sil-apply-substitution-map
branch
from
3c02380 to
c009650
Compare
DougGregor
changed the title
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Push SubstitutionMaps through most of SILGen, the SIL optimizers, and much of IRGen
that involve the various *ApplyInsts. Overall this eliminates ~100 more explicit uses of
SubstitutionList, and plumbs substitution maps through most of the infrastructure.