IRGen: Make sure we compare equal units in type size comparison #16453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is in some code to initialize variables for the debugger. From the original commit "Zero-initialize uninitialized Dictionary variables for the debugger. To avoid the debugger displaying garbage or having expressions crash when inspecting an uninitialized dictionary variable, zero-initialize the first word of the alloca at -Onone. " Unfortunately, we are comparing different quantities in that code. rdar://40043512
|
@swift-ci Please test and merge |
adrian-prantl
approved these changes
May 8, 2018
| @@ -4017,7 +4017,7 @@ void IRGenSILFunction::visitAllocStackInst(swift::AllocStackInst *i) { | |||
| return; | |||
|
|
|||
| auto &DL = IGM.DataLayout; | |||
| if (DL.getTypeSizeInBits(AI->getAllocatedType()) < DL.getPointerSize()) | |||
| if (DL.getTypeSizeInBits(AI->getAllocatedType()) < DL.getPointerSizeInBits()) | |||
There was a problem hiding this comment.
Ouch. Thanks! That makes sense.
|
@swift-ci Please smoke test linux |
|
@swift-ci Please test linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in some code to initialize variables for the debugger.
From the original commit
"Zero-initialize uninitialized Dictionary variables for the debugger.
To avoid the debugger displaying garbage or having expressions crash
when inspecting an uninitialized dictionary variable, zero-initialize
the first word of the alloca at -Onone.
"
Unfortunately, we are comparing different quantities in that code.
rdar://40043512