[stdlib] update the fatal error message displayed during invalid integer conversions #16480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to-int conversions (<rdar://39542040>)
|
@moiseev As I had discussed, I have removed "signed" qualifier from the error message printed during integer conversions. Let me know if the new error message sounds okay or if you would prefer to change it. Now if you do,
We used to get "Fatal error: Not enough bits to represent a signed value:" |
|
@swift-ci Please smoke test |
|
@swift-ci please smoke test |
|
It's not triggering for some reason... |
|
Yes it happens if there is a force push to the branch. |
|
@swift-ci please smoke test |
1 similar comment
|
@swift-ci please smoke test |
|
@swift-ci smoke test |
|
@swift-ci test |
|
Seems like all checks have passed. Good to be merged? |
|
Thanks @airspeedswift ! |
ravikandhadai
added a commit
to ravikandhadai/swift
that referenced
this pull request
Jun 15, 2018
…to-int conversions (<rdar://39542040>) (swiftlang#16480)
ravikandhadai
added a commit
that referenced
this pull request
Jun 15, 2018
[4.2][stdlib] update the fatal error message displayed during invalid int-to-int conversions (<rdar://39542040>) (#16480)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(rdar://39542040)