[crashers] Remove 91 fixed crashers that lack explicit Apache license text [WIP - removal might not be needed!] #1649
Conversation
practicalswift
changed the title
… text Prior to this commit: ``` $ git grep -E '[^a-zA-Z]MIT[^a-zA-Z]' | grep /compiler_crashers_fixed/ | wc -l 76 (+ 15 without the "MIT" string) $ ls validation-test/compiler_crashers_fixed/*.swift | wc -l 5083 ``` After this commit: ``` $ git grep -E '[^a-zA-Z]MIT[^a-zA-Z]' | grep /compiler_crashers_fixed/ | wc -l 0 $ ls validation-test/compiler_crashers_fixed/*.swift | wc -l 4992 ```
|
@practicalswift Thank you for working on this! Since this is a WIP pull request, do you want to add "WIP" in the subject? It sounds like you are looking for substitute tests before we remove these ones. |
|
The typical way we handle this is to try to contact the contributor of the test, to see if they're ok with relicensing. Is there any way to find out where these came from? |
|
@tkremenek This PR is not WIP actually :-) This commit only touches on So this PR simply deletes the 91 already fixed crash cases in The part you're referring to as WIP is probably the remaining 6 non-fuzzing crashes in So this PR is ready to go if you're okay it :-) |
|
@lattner That would be even better! I'll compile a list :-) |
|
Thank you @practicalswift, you continue to be amazing! |
practicalswift
changed the title
|
These are skilled compiler crash finders that discovered the (now fixed) crash cases in
|
|
I'm perfectly fine with my test being re-licensed. |
|
Sure, you can re-license my test as well. |
|
@lattner These crash cases in
|
|
And for the six remaining non-fixed crash cases (in
|
|
Feel free to re-license my contributions here if necessary. |
|
Likewise, feel free to re-license any crashers I’ve submitted. |
|
I give permission for any tests I've contributed to be re-licensed. Please let me know if any further action is required from me to make this happen. |
|
Please relicense my contributions as required. |
|
I'm also happy for my contributions to be re-licensed as necessary! |
|
Please relicense my contributions as necessary. |
|
I'm fine, go ahead and relicense if needed. |
|
Please, relicense as needed. |
|
Please relicense my contributions as needed. |
2 similar comments
|
Please relicense my contributions as needed. |
|
Please relicense my contributions as needed. |
|
Please re-license my code as needed. Thanks. Aaron Patterson
|
|
You can re-license my code as needed. Félix
|
|
I'm also good with relicensing :) |
|
Please relicense my contribution as needed. |
|
Feel free to relicense my contribution as well. |
|
Please relicense my contribution as needed as well.
|
|
Feel free to relicense the test I contributed as necessary. |
|
You can relicense my contributed tests as needed. |
|
You can relicense my contributed test.
|
|
Oh, somehow missed:
Sorry about that. |
|
Fine to relicense my test code. |
|
Please feel free to relicense my contributions in |
|
Greetings from Finland, my contributions can also be relicensed
|
|
Please relicense my contributions as required. |
|
Feel free to relicense my contribution as well. |
What's in this pull request?
This is a follow up to PR #1646.
/cc @tkremenek + @lattner
Prior to this commit:
After this commit:
After this commit there are six (6) crashers (non-fixed, non-fuzzing, not written by me) left that lack an explicit Apache license. These are:
Before deleting them I'd like to try to find fuzzing crash cases triggering the same crash locations as those.
I have a very large set of unpublished fuzzing crash cases that haven't been submitted for inclusion due to being "crash location duplicates" of other crash cases already in the repo. Hopefully I can find such independently discovered functionally equivalent crash cases ("duplicates") that can replace those five remaining mentioned above. I'll try doing so during the weekend.
Resolved bug number: –
Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
Validation Testing
Note: Only members of the Apple organization can trigger swift-ci.