-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[ASTMangler] Add support for mangling generic typealiases. #16519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@swift-ci please test |
Type reconstruction will come next, but, even with this patch alone, at least we don't crash when trying to print generic type aliases in lldb anymore :) |
Build failed |
Build failed |
@swift-ci please test |
Build failed |
Build failed |
It's a remangler failure:
otherwise, the changes generally look correct to be. @eeckstein is more the expert here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
This fails on ToT
I guess we weren't producing that name before. I'll take a look at this. |
Reduces to just:
Looks like we need a special treatment for mangling extensions here? |
<rdar://problem/39915946>
37a424c
to
f665943
Compare
@swift-ci please test |
Build failed |
Build failed |
rdar://problem/39915946
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.