Skip to content

Adjust access level of inaccessible protocol members in diagnostics. #16520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 11, 2018
Merged

Adjust access level of inaccessible protocol members in diagnostics. #16520

merged 1 commit into from
May 11, 2018

Conversation

rudkx
Copy link
Contributor

@rudkx rudkx commented May 11, 2018

Otherwise we hit one of the "%error" cases in the diagnostic text,
which results in an assert.

Fixes rdar://problem/40111079.

Otherwise we hit one of the "%error" cases in the diagnostic text,
which results in an assert.

Fixes rdar://problem/40111079.
@rudkx
Copy link
Contributor Author

rudkx commented May 11, 2018

@swift-ci Please smoke test

@rudkx
Copy link
Contributor Author

rudkx commented May 11, 2018

@slavapestov @xedin I couldn't find a way to trigger a problem here for the same/similar diagnostics in TypeCheckType.cpp and CalleeCandidateInfo.cpp, but if you can think of a way to do so let me know. The attempts I tried involving internal protocols all seemed to get caught in PreCheckExpression.

@rudkx rudkx merged commit baba206 into swiftlang:master May 11, 2018
@rudkx rudkx deleted the rdar40111079 branch May 11, 2018 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant