[Demangle to metadata] Support simple extension contexts. #16533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support demangling for types nested within some simple extension contexts. Still does not support nested types within constrained extensions that involve same-type constraints among generic parameters, nor deeply-nested types in extensions. However, it fixes rdar://problem/40071688.
|
@swift-ci please smoke test and merge |
xedin
reviewed
May 11, 2018
|
@DougGregor Thank you! |
jckarter
reviewed
May 16, 2018
| _typeByMangledName("4main4SG11VA2A2P1RzlE016InnerTConformsToC0VA2A2P3Rd__rlE018InnermostUConformsfG0VyAA08ConformsfC0V_AA0jf5P2AndG0V_AA0jF3P4aVG")!) | ||
|
|
||
| // Failure case: Dictionary's outer `Key: Hashable` constraint not sastified | ||
| // TODO: expectNil(_typeByMangledName("s10DictionaryV4mainE5InnerVyAC12ConformsToP1VSi_AC12ConformsToP1VG")) |
There was a problem hiding this comment.
Thanks for picking this up, Doug! Did you happen to test that this case gets rejected?
There was a problem hiding this comment.
I think this one ended up crashing in the runtime (!).
jckarter
reviewed
May 16, 2018
| // Failure case: SG11's inner `U: P2` constraint not satisfied | ||
| expectNil(_typeByMangledName("4main4SG11VA2A2P1RzlE016InnerTConformsToC0VyAA08ConformsfC0V_AHGMa")) | ||
|
|
||
| // TODO: Failure case: InnermostUConformsToP3's 'U: P3' constraint not satisfied |
There was a problem hiding this comment.
…or this case (which I didn't get around for forming the mangled name for, sorry)?
There was a problem hiding this comment.
I didn't conjure up the mangled name to test it either (sorry).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support demangling for types nested within some simple extension contexts.
Still does not support nested types within constrained extensions that
involve same-type constraints among generic parameters, nor
deeply-nested types in extensions. However, it fixes
rdar://problem/40071688.
This an updated version of #16287.