[4.2 2018-04-30][Demangle to metadata] Support simple extension contexts. #16540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support demangling for types nested within some simple extension contexts. Still does not support nested types within constrained extensions that involve same-type constraints among generic parameters, nor deeply-nested types in extensions. However, it fixes rdar://problem/40071688. (cherry picked from commit 0d438c9)
|
@swift-ci please test |
|
@swift-ci please nominate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Support runtime demangling for types nested within some simple extension contexts. There is more work to be done here, but this change is a strict improvement over what we had, and addresses a known regression from Swift 4.1.
Scope: Only affects the runtime, when demangling type names for types nested in extension contexts.
Radar/SR Issue: rdar://problem/40071688
Risk: Low risk; the runtime will currently fail on these cases. This change, while incomplete (i.e., we have additional known failures)
Testing: New tests for this functionality; compiler regression tests.
Reviewer: @jckarter