[Diagnostics] Hint contextual type diagnostics with expression type if known #16556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lution types This allows callees of `getPossibleTypesOfExpressionWithoutApplying` to get only unique types from the re-run of the solver.
…f known Avoid a re-typecheck in `diagnoseContextualConversionError` if the expression type is already known and only return `true` if we know that at least one error diagnostic has been emitted otherwise there is a risk that type-check is going to return without any and fail in verifier. Resolves: rdar://problem/40002266
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid a re-typecheck in
diagnoseContextualConversionErrorif theexpression type is already known and only return
trueif we knowthat at least one error diagnostic has been emitted otherwise there
is a risk that type-check is going to return without any and fail
in verifier.
Resolves: rdar://problem/40002266