Skip to content

Eliminate most uses of SubstitutionList #16563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
May 12, 2018
Merged

Eliminate most uses of SubstitutionList #16563

merged 17 commits into from
May 12, 2018

Conversation

DougGregor
Copy link
Member

Switch most clients of SubstitutionList over to SubstitutionMap, including:

  • All of SILGen's LValue infrastructure
  • SILGen's key-path emission code
  • Call emission in SILGen and IRGen
  • Lots of helpers that trafficked in SubstitutionList but are no longer used.

DougGregor added 17 commits May 11, 2018 17:37
@DougGregor
[SILOptimizer] Remove dead swift::hasArchetypes().
8c770f9
@DougGregor
[SIL] SubstitutionList -> SubstitutionMap in devirtualizer.
761b7c6
@DougGregor
[SIL] Remove SubstitutionList from the rest of the generic specializer.
42fe2c1
@DougGregor
[SILGen] Eliminate emitApplyOfLibraryIntrinsic() for SubstitutionList.
921d41c 
There was only one caller; update it to use the SubstitutionMap version.
@DougGregor
[SILGen] Eliminate useConformancesFromSubstitutions() on Substitution…
17572ce 
…List.

Update one caller first.
@DougGregor
[SILGen] Remove SubstitutionList from most of key-path SIL generation.
1af6cb9
@DougGregor
[IRGen] Eliminate SubstitutionList from IRGen.
7490289
@DougGregor
[SIL] Eliminate SubstitutionList from collectTypeDependentOperands().
3f5beab
@DougGregor
[SILPrinter] Eliminate SubstitutionList.
482f55d
@DougGregor
[SILGen] Eliminate more SubstitutionLists for accessor calls.
0bf0a1e
@DougGregor
[SILGen] Eliminate SubstitutionList from the LValue infrastructure.
c9b50e0
@DougGregor
[SILGen] Eliminate Substitution from key-path equals/hash generation.
5c0733f
@DougGregor
[SILGen] Simplify SubstitutionMap handling in emitApplyOfLibraryIntri…
9a0e57f 
…nsic.
@DougGregor
[SILGen] Eliminate SubstitutionList from SILGenFunction::emitApply().
cb3bf10
@DougGregor
Eliminate getForwardingSubstitutions().
049c56d 
Use the SubstitutionMap version everywhere.
@DougGregor
Eliminate dead code making use of SubstitutionList.
911ed60
@DougGregor
[SILGen] Get keypath emission logic off Substitution.
467456e
@DougGregor
Copy link
Member Author

@swift-ci please smoke test macOS

@DougGregor
Copy link
Member Author

@swift-ci please test Linux

@DougGregor
Copy link
Member Author

@swift-ci please test source compatibility

@DougGregor
Copy link
Member Author

Down to 25 utterances of "SubstitutionList" in the code base.

@slavapestov
Copy link
Contributor

For some reason my comments don’t show up properly. But feel free to fix those in a follow up patch.

@DougGregor
Copy link
Member Author

I'm going to merge and address your comments in a follow-up PR.

@DougGregor DougGregor merged commit 14b1499 into swiftlang:master May 12, 2018
@DougGregor DougGregor deleted the kill-more-substitution-lists branch May 12, 2018 03:51
@BasThomas BasThomas mentioned this pull request May 12, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DougGregor @slavapestov