Generic type alias access level regression #16570
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Swift 3 mode, the canonical private DeclContext should not look through extensions. The only way I can reproduce this is with a missing warning and we don't really care about missing warnings in Swift 3 mode. However, the next patch in this PR regresses more things so let's fix it properly.
If a property had an inferred type that is a generic type alias, we weren't checking the access level of the generic arguments. This used to work in 4.1 because we didn't have a sugared representation for generic type aliases, so we were checking the substituted underlying type here. But now that NameAliasType can store generic arguments, make sure we visit them here. Fixes <rdar://problem/40188409>.
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
|
@DougGregor assuming the tests pass are you OK with taking this into swift-4.2-branch and swift-4.2-branch-04-30-2018? |
|
@swift-ci Please smoke test Linux |
|
The Linux failure was unrelated, see #16575. I’m kicking off another run of the tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this while working on better checking of
@usableForInlineaccess control.If a property had an inferred type that is a generic type alias, we weren't checking the access level of the generic arguments.
This used to work in 4.1 because we didn't have a sugared representation for generic type aliases, so we were checking the substituted underlying type here. But now that NameAliasType can store generic arguments, make sure we visit them here.
Fixes rdar://problem/40188409.