[4.2] Cherry-pick dropping @inlinable and other cleanup #16593
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
@swift-ci please benchmark |
|
@swift-ci please test compiler performance |
|
@eeckstein, @lorentey this is a 4.2 cherry-pick of the other PRs |
lorentey
approved these changes
May 14, 2018
|
Build failed |
Build comment file:Build failed before running benchmark. |
|
!!! Couldn't read commit file !!! |
|
@swift-ci please test linux platform |
|
Build failed |
|
@swift-ci please test linux platform |
|
Build failed |
Aggressively remove all `@inlinable` from any function that's `@inline(never)` to see the impact. `@inlinable @inline(never)` is a potential code smell. While it might expose some optimization and specialization opportunities to the optimizer, it's most commonly a sign that more thought is needed.
Dropping many of Array's @inlinable annotations caused some performance regressions. Restore them temporarily while we figure out how to better annotate these decls.
Done to address benchmark regressions.
|
#16850 Included most of these. Still have the Array ones though... |
…ration We have no generic environment in this case, and just need to print the canonical generic parameter types. Fixes <https://bugs.swift.org/browse/SR-7673>.
|
@swift-ci test |
|
Build failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cherry-pick of #16578 and #16477