Add ExistentialToGeneric mangling and demangling code #16603
Conversation
| if (kindValue & | ||
| unsigned( | ||
| FunctionSigSpecializationParamKind::ExistentialToGeneric)) { | ||
| Buffer << 'e'; |
There was a problem hiding this comment.
It seems weird that this is an if/else if construct that duplicates some of the cases here. Can you instead redo this as a series of independent ifs instead?
There was a problem hiding this comment.
Not sure I follow. The idea here is that we allow "ARG-SPEC-KIND ::= 'e' 'D'? 'G'? 'X'? ---Generic argument, with optional dead, owned=>guaranteed or exploded-specifier". Please note the upper case and lower case. Let me know.
There was a problem hiding this comment.
Ok. It seems strange that the first letter is lower case and the rest are upper case, for each of the different argument kinds. But I guess that’s what we have today already.
|
@eeckstein please see the updated doc |
|
Thanks, lgtm! |
|
@swift-ci Please smoke test |
Add a new mangler/demangler option 'e' for ExistentialToGeneric needed for
#13991