[Serialization] Follow compatibility typealiases for non-generic types #16618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that we use the C names of imported types in mangled names, it's safe to resolve a compatibility alias when a type gets an NS_SWIFT_NAME for the first time, rather than requiring the developer to recompile the imported library. This doesn't include generic types, which only applies for Objective-C generics. There shouldn't be additional complications here but I want to be extra careful. rdar://problem/39661212
|
@swift-ci Please test |
DougGregor
approved these changes
May 15, 2018
jrose-apple
added a commit
to jrose-apple/swift
that referenced
this pull request
May 15, 2018
swiftlang#16618) Now that we use the C names of imported types in mangled names, it's safe to resolve a compatibility alias when a type gets an NS_SWIFT_NAME for the first time, rather than requiring the developer to recompile the imported library. This doesn't include generic types, which only applies for Objective-C generics. There shouldn't be additional complications here but I want to be extra careful. rdar://problem/39661212 (cherry picked from commit ec90545)
kitasuke
pushed a commit
to kitasuke/swift
that referenced
this pull request
Jun 9, 2018
swiftlang#16618) Now that we use the C names of imported types in mangled names, it's safe to resolve a compatibility alias when a type gets an NS_SWIFT_NAME for the first time, rather than requiring the developer to recompile the imported library. This doesn't include generic types, which only applies for Objective-C generics. There shouldn't be additional complications here but I want to be extra careful. rdar://problem/39661212
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we use the C names of imported types in mangled names, it's safe to resolve a compatibility alias when a type gets an NS_SWIFT_NAME for the first time, rather than requiring the developer to recompile the imported library.
This doesn't include generic types, which only applies for Objective-C generics. There shouldn't be additional complications here but I want to be extra careful.
rdar://problem/39661212